Closed unmeshvrije closed 1 year ago
Update the PR!
Regards, Unmesh Joshi
On Mon, 19 Sept 2022 at 11:14, robvk @.***> wrote:
@.**** requested changes on this pull request. In databases/sql/normalization.md https://github.com/HackYourFuture/study/pull/24#discussion_r974025651: - ID (PK) Name Country Code (FK) - 1 Apple US - 2 Lenovo CN +- DROP column Contact. +- ADD column Phone with the type int. I don't think we want the phone number to be an int, seems like a bad idea In databases/sql/normalization.md https://github.com/HackYourFuture/study/pull/24#discussion_r974026028: -If you want to increase your understanding, you can study the following materials: +2NF is violated here because + +``` +porj_budget (non prime column) Typo, think you mean: proj_budget — Reply to this email directly, view it on GitHub https://github.com/HackYourFuture/study/pull/24#pullrequestreview-1111933443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATCP7DWLFVFECMMOQVHR2LV7AVHTANCNFSM6AAAAAAQIWMGMU . You are receiving this because you authored the thread.Message ID: @.***>
In databases/sql/normalization.md https://github.com/HackYourFuture/study/pull/24#discussion_r974025651:
- ID (PK) Name Country Code (FK) - 1 Apple US - 2 Lenovo CN +- DROP column Contact. +- ADD column Phone with the type int.
+- DROP column Contact. +- ADD column Phone with the type int.
In databases/sql/normalization.md https://github.com/HackYourFuture/study/pull/24#discussion_r974026028:
-If you want to increase your understanding, you can study the following materials: +2NF is violated here because + +``` +porj_budget (non prime column)
Typo, think you mean: proj_budget
— Reply to this email directly, view it on GitHub https://github.com/HackYourFuture/study/pull/24#pullrequestreview-1111933443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATCP7DWLFVFECMMOQVHR2LV7AVHTANCNFSM6AAAAAAQIWMGMU . You are receiving this because you authored the thread.Message ID: @.***>
Update the PR!
Regards, Unmesh Joshi
On Mon, 19 Sept 2022 at 11:14, robvk @.***> wrote: