HackYourFutureBelgium / hackyourfuture.be

https://hackyourfuturebelgium.be
MIT License
4 stars 3 forks source link

Fix ESLint configuration #11

Closed jbelien closed 3 years ago

jbelien commented 3 years ago
Error: .eslintrc.js:
    Configuration for rule "required" is invalid:
    Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '{ some: [ "nesting", "id" ] }').

See https://github.com/HackYourFutureBelgium/hackyourfuture.be/runs/1194643281?check_suite_focus=true#step:6:11

lpmi-13 commented 3 years ago

which rule were you trying to add here? I'm not seeing anything for "required", "nesting", or "id" in the list of available rules here: https://eslint.org/docs/2.0.0/rules/

lpmi-13 commented 3 years ago

a working eslint config for warning on inner block declarations, for example, would look something like:

module.exports = {
  globals: {
    __PATH_PREFIX__: true,
  },
  extends: `react-app`,
  rules: {
    "no-inner-declarations": 1
  },
}
jbelien commented 3 years ago

which rule were you trying to add here? I'm not seeing anything for "required", "nesting", or "id" in the list of available rules here: https://eslint.org/docs/2.0.0/rules/

Indeed, I have no idea. .eslintrc.js was added by @KevinTss in abd8d283db8b84fafc61c61979bd6868737b4ce4

lpmi-13 commented 3 years ago

Ah, got it. Just to get CI working we could either remove that bit or add something similar to what I suggested above.