HackYourFutureBelgium / node-js

Node.js
MIT License
1 stars 17 forks source link

Class 23 - Week 2+3 Project #3

Open maeligg opened 4 months ago

maeligg commented 4 months ago

Please leave below a comment with a link to your week 2 project.

Instructions

PolyannaMeira commented 4 months ago

Here it is my project: https://github.com/PolyannaMeira/node-template

GKing3 commented 4 months ago

Here is a link to my forked repo: https://github.com/GKing3/node-template

stefan-000 commented 4 months ago

Here is a link to my forked repo: https://github.com/stefan-000/node-template

Kev-Ose commented 4 months ago

My repo link: https://github.com/Kev-Ose/node-template

nibishakajean commented 4 months ago

My repo click this link

Smita81 commented 4 months ago

https://github.com/Smita81/node-template/tree/node-template

Hammad1820 commented 3 months ago

Repo link: https://github.com/Hammad1820/node-template

pallavisarwar commented 3 months ago

My Project link :

https://github.com/pallavisarwar/node-template/tree/pallavi-node-template-project

Gemechis10 commented 3 months ago

https://github.com/Gemechis10/node-template

juryp commented 3 months ago

Link to my forked repo: https://github.com/juryp/node-template

maeligg commented 3 months ago

Here it is my project: https://github.com/PolyannaMeira/node-template

@PolyannaMeira the recipes routes look good, are you planning to implement the user routes ?

maeligg commented 3 months ago

Here is a link to my forked repo: https://github.com/GKing3/node-template

@GKing3 good start, but you're missing some recipe controllers that are not implemented such as postRecipe, updateRecipe, and all the user ones.

maeligg commented 3 months ago

Here is a link to my forked repo: https://github.com/stefan-000/node-template

@stefan-000 do you need any help ? You need to update the SQL queries to perform the correct operation, handle the errors in case the correct parameters are not passed to the route, and return the correct HTTP status code in the response.

maeligg commented 3 months ago

My repo link: https://github.com/Kev-Ose/node-template

@Kev-Ose I don't see any changes compared to the template, do you need any help ?

maeligg commented 3 months ago

My repo click this link

@nibishakajean this looks great, congrats !

maeligg commented 3 months ago

https://github.com/Smita81/node-template/tree/node-template

@Smita81 be careful that you created a duplicate .Env file, I think that's probably an error ? You should only have 1 .env file (all lowercase). I'm not sure what the HTML pages are for, I don't think they are used anywhere in the app were you testing something with them ?

maeligg commented 3 months ago

Repo link: https://github.com/Hammad1820/node-template

@Hammad1820 I don't see any changes on the main branch, did you push your code ?

maeligg commented 3 months ago

My Project link :

https://github.com/pallavisarwar/node-template/tree/pallavi-node-template-project

@pallavisarwar I left some comments on your pull request https://github.com/HackYourFutureBelgium/node-template/pull/10

maeligg commented 3 months ago

https://github.com/Gemechis10/node-template

@Gemechis10 I don't see any changes to the template, did you push your code ?

maeligg commented 3 months ago

Link to my forked repo: https://github.com/juryp/node-template

@juryp This looks good, but what is the totalYield field that you defined on the postRecipe and updateRecipe controllers ? It's not defined in the model so I don't think it would work. Also I noticed you didn't update the .env file, did you just change it locally and not push your changes ? Is it working for you ?

Smita81 commented 3 months ago

@maeligg thanks for your review. here is the link after corrections. https://github.com/Smita81/node-template I am not able to login for this project in postman .