Hacker0x01 / hai-on-hackerone

3 stars 1 forks source link

replace bcolors with termcolor #17

Closed iMartzen closed 2 months ago

iMartzen commented 2 months ago

Issue number and link

Closes: https://github.com/Hacker0x01/hai-on-hackerone/issues/6

๐Ÿ“ Summary

This merge request is linked to issue #6. The main change is updating the print statement for colored console output. The previous method using bcolors has been replaced with the colored function for better readability and maintainability.

๐Ÿงช Test Plan

  1. Run the script to verify that the output "Response from Hai" is displayed in light blue.
  2. Ensure that there are no errors related to the colored function.
  3. Check the terminal to confirm the color change from the old method to the new method.

๐Ÿค” Additional remarks

Switching to the colored function simplifies the code and improves consistency in how colors are applied across the project.

โœ… Review Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 76.28866% with 23 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (2507518) to head (8d8957a).

Files Patch % Lines
cli/actions.py 7.69% 12 Missing :warning:
cli/hai.py 40.00% 6 Missing :warning:
cli/reports.py 60.00% 4 Missing :warning:
cli/main.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================== + Coverage 63.07% 69.41% +6.33% ========================================== Files 9 10 +1 Lines 455 497 +42 ========================================== + Hits 287 345 +58 + Misses 168 152 -16 ``` | [Flag](https://app.codecov.io/gh/Hacker0x01/hai-on-hackerone/pull/17/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hacker0x01) | Coverage ฮ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/Hacker0x01/hai-on-hackerone/pull/17/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hacker0x01) | `69.41% <76.28%> (+6.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hacker0x01#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.