Closed yuki0410-dev closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.29%. Comparing base (
d221037
) to head (68be138
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mirus-ua (@martijnrusschen ) The Codecov Report has indicated a drop in coverage, but as you can see from the diff, I only added the TS type and made no changes to the JS implementation part. Should I still prevent the coverage rate from dropping in this case?
@mirus-ua (@martijnrusschen ) The Codecov Report has indicated a drop in coverage, but as you can see from the diff, I only added the TS type and made no changes to the JS implementation part. Should I still prevent the coverage rate from dropping in this case?
No, this is expected
@martijnrusschen The changes you want to use in tsing another file are included in this PR. Please merge if it is OK.
name: Migrate year_dropdown.jsx and year_dropdown_options.jsx
Description
Linked issue: #4700
Changes
year_dropdown.jsx and year_dropdown_options.jsx
was migrated to ts and testContribution checklist