Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React
https://reactdatepicker.com/
MIT License
7.92k stars 2.23k forks source link

[typescript-migration] year_dropdown.jsx and year_dropdown_options.jsx #4715

Closed yuki0410-dev closed 2 months ago

yuki0410-dev commented 2 months ago

name: Migrate year_dropdown.jsx and year_dropdown_options.jsx

Description

Linked issue: #4700

Changes year_dropdown.jsx and year_dropdown_options.jsx was migrated to ts and test

Contribution checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.29%. Comparing base (d221037) to head (68be138). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4715 +/- ## ========================================== + Coverage 97.23% 97.29% +0.06% ========================================== Files 22 19 -3 Lines 2132 1961 -171 Branches 916 850 -66 ========================================== - Hits 2073 1908 -165 + Misses 59 53 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuki0410-dev commented 2 months ago

@mirus-ua (@martijnrusschen ) The Codecov Report has indicated a drop in coverage, but as you can see from the diff, I only added the TS type and made no changes to the JS implementation part. Should I still prevent the coverage rate from dropping in this case?

mirus-ua commented 2 months ago

@mirus-ua (@martijnrusschen ) The Codecov Report has indicated a drop in coverage, but as you can see from the diff, I only added the TS type and made no changes to the JS implementation part. Should I still prevent the coverage rate from dropping in this case?

No, this is expected

yuki0410-dev commented 2 months ago

@martijnrusschen The changes you want to use in tsing another file are included in this PR. Please merge if it is OK.