Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React
https://reactdatepicker.com/
MIT License
8.06k stars 2.24k forks source link

[typescript-migration] popper_component.jsx #4740

Closed yuki0410-dev closed 5 months ago

yuki0410-dev commented 5 months ago

name: Migrate popper_component.jsx

Description

Linked issue: #4700

Changes popper_component.jsx was migrated to ts

Contribution checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.35%. Comparing base (68e9893) to head (979ab4c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4740 +/- ## ========================================== - Coverage 96.41% 96.35% -0.06% ========================================== Files 9 8 -1 Lines 975 959 -16 Branches 447 442 -5 ========================================== - Hits 940 924 -16 Misses 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuki0410-dev commented 5 months ago

@martijnrusschen If there are no other problems, I would be happy to merge them.

martijnrusschen commented 5 months ago

apologies, I'm on vacation this week and don't have the ability to review or merge anything until Friday.

On Sun, Apr 28, 2024 at 4:49 PM yuki0410 @.***> wrote:

@martijnrusschen https://github.com/martijnrusschen If there are no other problems, I would be happy to merge them.

— Reply to this email directly, view it on GitHub https://github.com/Hacker0x01/react-datepicker/pull/4740#issuecomment-2081510079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKY2KBYXCOMQJCP534L2ATY7UD6VAVCNFSM6AAAAABG3SULRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGUYTAMBXHE . You are receiving this because you were mentioned.Message ID: @.***>

yuki0410-dev commented 5 months ago

Understood. Have a nice vacation.

martijnrusschen commented 5 months ago

Looks like there's a failing test, can you check?

yuki0410-dev commented 5 months ago

@martijnrusschen Rebased.