[typescript-migration] add type-check to gh actions

Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React

https://reactdatepicker.com/

MIT License

7.92k stars 2.23k forks source link

[typescript-migration] add type-check to gh actions #4749

Closed mirus-ua closed 2 months ago

mirus-ua commented 2 months ago

name: add type-check to gh actions

Description

Linked issue: https://github.com/Hacker0x01/react-datepicker/issues/4700

Changes I extended the existing Github action called test.yml rather than creating a new one because this action already contains the rest of the checks, including eslint and prettier

Contribution checklist

[x] I have followed the contributing guidelines.
[x] I have added sufficient test coverage for my changes.
[x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

mirus-ua commented 2 months ago

@yuki0410-dev hello. could you help me and tell if the DatePicker › should update the preSelection state when a day is selected with mouse click test is also failing on the latest main branch 0cb6f84237a5db65dc3fb0c454b3ac3a40683f0c

yuki0410-dev commented 2 months ago

@mirus-ua I tried it locally and it also failed on the main branch. As far as I have tried, it occurs when I rewind the PC date by a week or so, which means that the date (end of the month?) is not the same as the date. I think it has something to do with the date (end of the month?) and the day of the week. I have fixed that error in #4747.

mirus-ua commented 2 months ago

@mirus-ua I tried it locally and it also failed on the main branch. As far as I have tried, it occurs when I rewind the PC date by a week or so, which means that the date (end of the month?) is not the same as the date. I think it has something to do with the date (end of the month?) and the day of the week. I have fixed that error in #4747.

Thank you for your help. So, if you already fixed the problem in your PR, we'll merge your first and then go with this one

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.26%. Comparing base (0cb6f84) to head (7ccb8b1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4749 +/- ## ======================================= Coverage 97.26% 97.26% ======================================= Files 11 11 Lines 1462 1462 Branches 642 652 +10 ======================================= Hits 1422 1422 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.