[typescript-migration] filter_times_test.test.js

Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React

https://reactdatepicker.com/

MIT License

7.89k stars 2.23k forks source link

[typescript-migration] filter_times_test.test.js #4815

Closed yasuaki640 closed 1 month ago

yasuaki640 commented 1 month ago

name: Migrate filter_times_test.test.js

Description

Linked issue: #4700

Changes Changes filter_times_test.test.js was migrated to tsx.

Added type narrowing by if statement because the return value of Node.textContent is nullable.

Contribution checklist

[x] I have followed the contributing guidelines.
[x] I have added sufficient test coverage for my changes.
[x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

martijnrusschen commented 1 month ago

Build is failing due to a ratelimit issue on codecov. I have a fix (https://github.com/Hacker0x01/react-datepicker/pull/4816) ready which I'll merge shortly. Please rebase this PR afterwards.

martijnrusschen commented 1 month ago

Fix has been merged. Please rebase.

martijnrusschen commented 1 month ago

@yasuaki640 please merge the latest master into this PR

yuki0410-dev commented 1 month ago

@yasuaki640 ( @martijnrusschen ) The filter_times_test.test.js is TS'd with PR #4810, do we need to make any additional modifications? We recommend that you import the latest main branch and check it once.