[Proposal] yarn to npm - Githubissues

Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React

https://reactdatepicker.com/

MIT License

7.89k stars 2.23k forks source link

[Proposal] yarn to npm #4904

Open yuki0410-dev opened 1 week ago

yuki0410-dev commented 1 week ago

Description: I suggest moving from yarn to npm.

Linked issue: -

Problem

Some PACKAGES cannot be added or removed because they use yarn v1.
- https://github.com/yarnpkg/yarn/issues/4812
- https://github.com/Hacker0x01/react-datepicker/blob/114f06adfdaee028e3442438cc9bb7c97199be32/docs-site/package.json#L39C6-L39C16

Changes

Migrated package manager from yarn to npm.
- Fixed Github Actions.
Removed unnecessary packages that were blocked due to yarn v1.
Organized the naming of npm scripts since there was no regularity in naming them.

Contribution checklist

[x] I have followed the contributing guidelines.
[x] I have added sufficient test coverage for my changes.
[x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.67%. Comparing base (f90932c) to head (c86a0e8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4904 +/- ## ======================================= Coverage 96.67% 96.67% ======================================= Files 28 28 Lines 3275 3275 Branches 1357 1358 +1 ======================================= Hits 3166 3166 + Misses 109 105 -4 - Partials 0 4 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuki0410-dev commented 1 week ago

However, changing from yarn to npm is a fairly significant change to be occurring without previous consensus on doing so.

I agree. I created the PR as a suggestion, hoping that you would be able to judge from the specific changes!

Personally, I don't see the need for it, particularly as there is a workaround that is already being used.

There are some PACKAGES that cannot be deleted due to the use of YARN. https://github.com/Hacker0x01/react-datepicker/pull/4896

I have not had any problems at all with npm.

However this decision is up to the HackerOne team.

I think you are right.

yuki0410-dev commented 1 week ago

@martijnrusschen What do you think about this change? We are willing to resolve conflicts if the policy seems acceptable.