Fix: DatePickerProps - Githubissues

Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React

https://reactdatepicker.com/

MIT License

7.89k stars 2.23k forks source link

Fix: DatePickerProps #4905

Closed yuki0410-dev closed 1 week ago

yuki0410-dev commented 1 week ago

Description

Linked issue: #4899

Problem

See issue

Changes

fix DatePickerProps

Contribution checklist

[x] I have followed the contributing guidelines.
[x] I have added sufficient test coverage for my changes.
[x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.66%. Comparing base (114f06a) to head (2d33634).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4905 +/- ## ======================================= Coverage 96.66% 96.66% ======================================= Files 28 28 Lines 3264 3264 Branches 1343 1343 ======================================= Hits 3155 3155 Misses 109 109 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martijnrusschen commented 1 week ago

Should this get test coverage?

yuki0410-dev commented 1 week ago

@martijnrusschen The Props are used below, but customInput itself is a very flexible type that would be difficult to guarantee with type checking and testing.

https://github.com/Hacker0x01/react-datepicker/blob/114f06adfdaee028e3442438cc9bb7c97199be32/src/index.tsx#L1346

https://github.com/Hacker0x01/react-datepicker/blob/114f06adfdaee028e3442438cc9bb7c97199be32/src/index.tsx#L161