Open yuki0410-dev opened 1 week ago
Attention: Patch coverage is 71.05263%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 96.35%. Comparing base (
f90932c
) to head (ee69d7b
).
Files | Patch % | Lines |
---|---|---|
src/index.tsx | 71.05% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
it looks like the test coverage took a hit, can you review this?
@martijnrusschen I just formally describe the fallback because defaultProps is not reflected in the type well, and I can't actually get the code to pass here. (I can write this code well if it is a function Component instead of a Class Component.) A similar case occurred during the typescript transition, and we believe that it cannot be helped.
Description
Linked issue: closes #4922
Problem See issue
Changes
Pick<AdditionalProps, "excludeScrollbar">
Contribution checklist