fix style for quarter - Githubissues

Hacker0x01 / react-datepicker

A simple and reusable datepicker component for React

https://reactdatepicker.com/

MIT License

8.06k stars 2.24k forks source link

fix style for quarter #4948

Closed asada-no4 closed 2 months ago

asada-no4 commented 3 months ago

Description

Linked issue: #4219

Problem Quarter Picker with "excludeDates" is not getting inactive styles. Please check the issue for details.

Changes

Include "excludeDates" as a condition for calling the Quarter Picker's disable judge function.

Contribution checklist

[ ] I have followed the contributing guidelines.
[ ] I have added sufficient test coverage for my changes.
[ ] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

asada-no4 commented 3 months ago

Sorry...

https://github.com/Hacker0x01/react-datepicker/blob/main/src/year.tsx#L370

I have modified the call condition again to match the above.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.71%. Comparing base (17a0a33) to head (5db1ad2).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4948 +/- ## ========================================== - Coverage 96.71% 96.71% -0.01% ========================================== Files 28 28 Lines 3287 3285 -2 Branches 1368 1366 -2 ========================================== - Hits 3179 3177 -2 Misses 104 104 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asada-no4 commented 3 months ago

Sorry for repeating myself.

"excludeDate" and "includeDate" tests added. The "filterDate" test has not been added to match MONTH.

martijnrusschen commented 2 months ago

@asada-no4 please fix the prettier error so we can merge this

asada-no4 commented 2 months ago

Sorry. I ran "yarn run prettier".