HackerExperience / HEBorn

GNU Affero General Public License v3.0
56 stars 18 forks source link

Fix 'password_acquired' kill 'process_created' event #486

Closed themaxhero closed 6 years ago

themaxhero commented 6 years ago
PedroHLC commented 6 years ago

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


src/Decoders/Processes.elm, line 47 at r1 (raw file):

        |> custom type_
        |> required "access" access
        |> optional "state" state Starting

This is wrong, this is only optional for ProcessCreated, you should duplicate this decoder and only use it in ProcessCreated


Comments from Reviewable

PedroHLC commented 6 years ago

Reviewed 9 of 9 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

PedroHLC commented 6 years ago

<img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable