[POC] Automation for Electron apps

HackerExperience / HEBorn

GNU Affero General Public License v3.0

56 stars 18 forks source link

[POC] Automation for Electron apps #490

Closed chrisfls closed 7 months ago

chrisfls commented 6 years ago

This is kinda ready, the only leftover is to fix the API url.

The code is building an app for every architecture of platform, including mas (we'll probably ditch "Mac Apple Store" because steam)

Not sure if it should be merged, I think it's HE2 only, so it's probably not going to be merged now, but kept as a basis for the future (I might be wrong).

Note: Most of the names are HE2 related (the .exe name is Hacker Experience 2.exe).

This change is

PedroHLC commented 6 years ago

Didn't expected this so soon, but it seems fine!

Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

chrisfls commented 6 years ago

It's not ready because I don't know what values we should use for the flags.

chrisfls commented 6 years ago

Changes:

Added electron dependency to package.json, I've assumed it wasn't needed and removed it before, but it's really needed;
Added support for running the app with development server (read electron.js and static/main.js), it has more to do with invalid certificate problems and spawning the devtools;
Added electron.js with build instructions, it replaces the previous electron-packager in the Makefile, the main reason for that is to moves files around to fix the problem bellow;
Fixed static file loading, now images load just fine like on production (can't say the same for the wallpaper);

chrisfls commented 6 years ago

And now bsd compatibility is biting us again :cry:

chrisfls commented 6 years ago

Note: this is really almost ready to merge, additional comments on our private discord dev channel.