Closed renatomassaro closed 7 years ago
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 11 commits behind the HackerExperience:master
branch, and a review of an up to date branch would produce more accurate results.
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/241.
Reviewed 85 of 85 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
This PR fixes #235, or, actually, invalidates it.
Once we define one or more
else
conditions withinwith
, dialyzer won't be happy if we leave unmatched patterns.This change is