Closed renatomassaro closed 7 years ago
@mememori now that there are a lot of integrated tests, we are getting a high rate of username collision. You might want to prioritize this issue: https://github.com/HackerExperience/burette/issues/4
@mememori now that there are a lot of integrated tests, we are getting a high rate of username collision. You might want to prioritize this issue: HackerExperience/burette#4
Okay. Leave it to me
As far as Bank is concerned, this PR is finished. However, I still have to:
master
and bank
here@mememori with that in mind, you can start your review process. Good luck. Meanwhile I'll start Bitcoin Virus (based on this PR).
Edit: My bad, we should review this one only after #239 and #249 have been merged, otherwise unrelated changes appear on the Reviawlbalwerble app.
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/250.
Reviewed 153 of 184 files at r1, 19 of 36 files at r2, 16 of 18 files at r3, 3 of 3 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Depends on #239 and #249
[1] - it's not fully implement with Cracker to avoid conflicts with #249. Once it's merged, I'll add BufferOverflow as a module of Cracker, and merge both (like LogForger create/edit).
(Note to self: merging is not a requirement, and if both (file) modules behave differently enough, it does make sense to keep them on separate (elixir) modules)
Incidental:
close_connections_where/4
Yeah, this stuff will bloat this PR, but 1) it was a pain point 2) many bank-related tests would need refactor anyway 3) a different PR would depend on this one (and this one would depend on the other PR) 4) just do it
This change is