HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Join server channel using NIPs instead of ServerID #276

Closed renatomassaro closed 7 years ago

renatomassaro commented 7 years ago

Depends on #267

Closes #273

TODO:


Incidental:


This change is Reviewable

#

renatomassaro commented 7 years ago

Reviewed 37 of 37 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


lib/server/websocket/channel/server.ex, line 30 at r1 (raw file):

  "server:<network_id>@<destination_ip>[#<counter>]"

  [#<counter>] denotes optional argument. If omitted, counter=0 will be assumed.

Enhance doc


Comments from Reviewable

sourcelevel-bot[bot] commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/276.

renatomassaro commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable