HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Add ClientHash to allow the same Phoenix Channel to be joined more than once #277

Closed renatomassaro closed 6 years ago

renatomassaro commented 6 years ago

Problem: specially with Server Channels (because of ChannelState counter) we limit the number of simultaneously open channels with the same counter at the same target (nip).

Another solution, other than allowing the client to specify a custom-generated UUID, is to allow external clients to "merge" another client's socket. This is probably not trivial, and the former solution is probably a lot easier, at the expense of one extra parameter for every channel join.

Postponed until need arises.

renatomassaro commented 6 years ago

Fixed on PR #273