Closed renatomassaro closed 6 years ago
Reviewed 23 of 24 files at r1, 4 of 4 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.
lib/log/model/loggable/flow.ex, line 154 at r2 (raw file):
database, emitting the relevant `LogCreatedEvent` """ def save([]),
Move the save/1
function to the EventHandler, so it stays out of the model.
test/log/event/handler/log_test.exs, line 24 at r2 (raw file):
@tag :pending test "creates log" end
Review this, I think it's on another scope / already tested
Comments from Reviewable
Reviewed 53 of 54 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/281.
Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Depends on #271
Closes #278
TODO:
all_events
(cf https://github.com/HackerExperience/HELF/pull/26)Incidental:
inserted_at
tocreation_time
This change is![Reviewable](https://reviewable.io/review_button.svg)