Closed renatomassaro closed 6 years ago
Reviewed 7 of 7 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.
lib/event/dispatcher/helix.ex, line 33 at r1 (raw file):
all_events StoryHandler, :step_handler # TODO: Rearrange on PR 284
Rearrange
Comments from Reviewable
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 3 commits behind the HackerExperience:master
branch, and a review of an up to date branch would produce more accurate results.
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/284.
Reviewed 3 of 3 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Review status: all files reviewed at latest revision, 1 unresolved discussion.
lib/event/dispatcher/helix.ex, line 33 at r1 (raw file):
Rearrange
Done.
Comments from Reviewable
Depends on #281
With HELF.Event supporting global handlers through the
all_events
macro, the separation of Dispatchers is no longer desired.This change is![Reviewable](https://reviewable.io/review_button.svg)