search

HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Public FTP #301

Closed renatomassaro closed 7 years ago

renatomassaro commented 7 years ago

TODO:

Incidental:

This change is Reviewable

renatomassaro commented 7 years ago

Reviewed 87 of 92 files at r1, 11 of 11 files at r2. Review status: all files reviewed at latest revision, 8 unresolved discussions.

lib/entity/henforcer/entity.ex, line 31 at r2 (raw file):

  @type owns_server_relay :: %{entity: Entity.t, server: Server.t}
  @type owns_server_relay_partial :: owns_server_relay

extra line

lib/event/loggable/utils.ex, line 19 at r2 (raw file):

  @unknown_ip "Unknown"

  def format_ip(ip),

This method is private

lib/event/loggable/utils.ex, line 81 at r2 (raw file):

  """
  defp char_is_number?(char),
    # do: char in [48, 49, 50, 51, 52, 53, 54, 55, 56, 57]

rm

lib/hell/hell/hector.ex, line 325 at r2 (raw file):


    Enum.map(result.rows, fn row ->
      if :erlang.function_exported(module, :hector_loader, 2) do

Document this feature

lib/hell/hell/utils.ex, line 60 at r2 (raw file):

    do: concat(a, b) |> concat(c)

  def atom_contains?(a, value) when is_atom(a) do

docme

lib/software/public/file.ex, line 59 at r2 (raw file):

  end

  def pftp_download(network_id, gateway_id, pftp, storage, file) do

rm me

lib/software/public/file.ex, line 71 at r2 (raw file):

  end

  # def pftp_add_file(pftp = %PublicFTP{}, file = %File{}) do

rm me

test/support/channel/request/macros.ex, line 11 at r2 (raw file):

    end
  end

rm

Comments from Reviewable

sourcelevel-bot[bot] commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/301.

renatomassaro commented 7 years ago

Reviewed 6 of 6 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable