HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Support custom request ID #329

Closed renatomassaro closed 6 years ago

renatomassaro commented 6 years ago

Closes #323


If the client sends a request_id alongside the request parameters, the response will include this same request_id, and any events fired as a result/side-effect of this request will also contain the request_id.

Incidental


This change is Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/329.

renatomassaro commented 6 years ago

Reviewed 58 of 58 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.


lib/software/public/index.ex, line 56 at r1 (raw file):

  end

  def render_file(file = %File{}) do

spec


lib/websocket/request.ex, line 121 at r1 (raw file):

end

defmodule Helix.Websocket.Request.Relay do

move to a separate file


Comments from Reviewable

renatomassaro commented 6 years ago

Reviewed 11 of 11 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable