Closed renatomassaro closed 7 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/329.
Reviewed 58 of 58 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.
lib/software/public/index.ex, line 56 at r1 (raw file):
end def render_file(file = %File{}) do
spec
lib/websocket/request.ex, line 121 at r1 (raw file):
end defmodule Helix.Websocket.Request.Relay do
move to a separate file
Comments from Reviewable
Reviewed 11 of 11 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Closes #323
If the client sends a
request_id
alongside the request parameters, the response will include this samerequest_id
, and any events fired as a result/side-effect of this request will also contain therequest_id
.Incidental
ProcessCreatedEvent.Notificable
implementation by delegating the full/partial access logic to the correct place (ie the renderer atPublicProcessView
, which delegates toProcess.Viewable
).This change is