Storyline Setup

[renatomassaro]

This commit was meant to create the first setup process of the very first Step, which consists of

• creating a server for the NPC
• creating a cracker to be downloaded
• putting that cracker into a PublicFTP

Quite simple, right? However in order to support this generation system in a maintainable way, this commit lays the ground for storyline data setup, regeneration and teardown.

• [x] ServiceMake pattern

  • [x] Entity
  • [x] Software
  • [x] Server
  • [x] NPC
  • [x] Tests

• [x] Enhancements on the Step underlying macros

• [x] Storyline flow test

• Step-specific setup/teardown test. Not now

---

This change is 

[renatomassaro]

Reviewed 43 of 46 files at r1, 5 of 5 files at r2. Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks broke.

---

lib/entity/make/entity.ex, line 6 at r2 (raw file):

  alias Helix.Entity.Action.Entity, as: EntityAction

  def entity(npc = %NPC{}, _data \\ %{}) do

spec much

---

lib/server/make/server.ex, line 18 at r2 (raw file):

  - hardware: Specs?
  """
  def server(entity = %Entity{}, data) do

spec much

---

lib/software/make/pftp.ex, line 13 at r2 (raw file):

  end

  def add_file(file = %File{}, pftp = %PublicFTP{}, _data \\ %{}) do

spec much

---

lib/story/event/step.ex, line 67 at r2 (raw file):

      }
    end

doc + spec + extra space

---

lib/story/mission/tutorial/steps.ex, line 56 at r2 (raw file):

      send: "give_more_info"

    defp create_char do

abstract to a mission helper or something like that

---

test/features/process/lifecycle_test.exs, line 80 at r2 (raw file):

    # a file of about ~1kb, which takes less than a second.
    test "spontaneous completion" do
      # TODO ready

pls

---

test/features/storyline/flow_test.exs, line 37 at r2 (raw file):

      # Register player at the first step
      # TODO: This should be done as a response of AccountCreatedEvent

open issue

---

Comments from Reviewable

[sourcelevel-bot[bot]]

Ebert has finished reviewing this Pull Request and has found:

• 4 possible new issues (including those that may have been commented here).
• 2 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/334.

[renatomassaro]

Reviewed 13 of 13 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable