HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Add Logflix #347

Closed renatomassaro closed 6 years ago

renatomassaro commented 7 years ago

Watch live streaming of logs for free!

Internal tool for development debugging and for production logging.

Closes #346


This change is Reviewable

renatomassaro commented 6 years ago

Reviewed 51 of 51 files at r1. Review status: all files reviewed at latest revision, 9 unresolved discussions.


lib/logger.ex, line 9 at r1 (raw file):

  """

  # @dialyzer {:nowarn_function, 'Elixir.Timber.add_context': 1}

remove me


lib/logger.ex, line 19 at r1 (raw file):

  defmacro __using__(_) do
    quote do
      @dialyzer [:no_improper_lists, :no_return, :no_contracts, :no_match]

rm


lib/logger.ex, line 75 at r1 (raw file):

      end

    data = Keyword.get(opts, :data, %{})

Move it to logical block below


lib/logger.ex, line 87 at r1 (raw file):

    # it is used by the Timber API, and on `dev` it's used on the Logflix API).
    event =
      if data == %{} do

Enum.empty?


lib/account/websocket/channel/account/join.ex, line 21 at r1 (raw file):

  alias Helix.Account.Public.Account, as: AccountPublic

  def log_error(request, _socket, reason) do

Move to the end of the module


lib/hell/hell/logflix.ex, line 5 at r1 (raw file):

channel HELL.Logflix do
  @moduledoc """
  Watch live streaming of logs... for free!!11!

Document it only exists on :dev


lib/server/websocket/channel/server/join.ex, line 35 at r1 (raw file):

  alias Helix.Server.Websocket.Channel.Server.Join, as: ServerJoin

  def log_error(request, _socket, reason) do

Move to the end of the function


lib/websocket/websocket.ex, line 130 at r1 (raw file):


      _ ->

extra line


lib/websocket/join/joinable.ex, line 87 at r1 (raw file):

  def join(request, socket, assign)

  def log_error(request, socket, reason)

specs + doc


Comments from Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

But beware that this branch is 4 commits behind the HackerExperience:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/347.

renatomassaro commented 6 years ago

Reviewed 6 of 6 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable