HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Only log "Localhost logged in" upon login (ignore WS reconnection) #355

Open renatomassaro opened 6 years ago

renatomassaro commented 6 years ago

Currently, Helix naively logs "Localhost logged in" every time the channel is joined, but it may be the case that this join is due to websocket reconnection (internal/transparent to the user). We should detect that a login request was performed (POST /v1/account/login) and only then create the log.

Deathslayer222 commented 6 years ago

im my opinion that may make the game harder which is always good meaning u have to check ur logs more therefore u also may see enemys

renatomassaro commented 6 years ago

@Deathslayer222 the main problem is this is a "penalty"[1] totally random from the player point of view (every deployment would result in this log message being generated, as well as player disconnection e.g. switching from mobile data to cable)

[1] - Though to be honest I don't see "Localhost logged in" as a penalty in any way. It's just annoying, since it spams the LogViewer

Deathslayer222 commented 6 years ago

I understand that