Closed renatomassaro closed 6 years ago
Reviewed 14 of 14 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.
lib/account/public/account.ex, line 33 at r1 (raw file):
def bootstrap(entity_id) do entity = EntityQuery.fetch(entity_id)
Mention this can be optimized in the future
lib/account/public/index/inventory.ex, line 106 at r1 (raw file):
to the client also tells whether it is being used or not. """ defp get_linked_components(components) do
Move this method to the end of the module
Comments from Reviewable
Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 1 commit behind the HackerExperience:master
branch, and a review of an up to date branch would produce more accurate results.
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/356.
Includes player inventory on AccountBootstrap.
Currently, inventory includes:
This change is![Reviewable](https://reviewable.io/review_button.svg)