HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Add MotherboardUpdateRequest #357

Closed renatomassaro closed 6 years ago

renatomassaro commented 6 years ago

TODO

Incidental

This change is Reviewable

renatomassaro commented 6 years ago

Reviewed 54 of 54 files at r1. Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.


lib/entity/henforcer/entity.ex, line 83 at r1 (raw file):

    {true, owns_component_relay}
    | owns_component_error
  def owns_component?(entity_id = %Entity.ID{}, component, owned) do

Doc henforcers


lib/server/event/motherboard.ex, line 5 at r1 (raw file):

  import Helix.Event

  event Updated do

doc everywhere


lib/server/henforcer/component.ex, line 1 at r1 (raw file):

defmodule Helix.Server.Henforcer.Component do

docdocdoc


lib/server/henforcer/server.ex, line 22 at r1 (raw file):

  Ensures the requested server exists on the database.
  """
  # TODO: REVIEW: Why does it accept `Server.t` as input?

Reviewed. Remove.


lib/server/public/server.ex, line 57 at r1 (raw file):

  ::
    ServerFlow.update_mobo_result
  def update_mobo(server, {mobo, components, ncs}, entity_ncs, relay) do

doc


lib/server/websocket/channel/server.ex, line 130 at r1 (raw file):


  @doc """
  Errors:

Missing params and return sections


Comments from Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/357.

renatomassaro commented 6 years ago

Reviewed 12 of 13 files at r2, 7 of 7 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable