Closed renatomassaro closed 6 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/360.
Reviewed 120 of 120 files at r1. Review status: all files reviewed at latest revision, 7 unresolved discussions.
lib/cache/action/cache.ex, line 232 at r1 (raw file):
| server_cache :: ServerCache.t | nil | term # YOLO
:dancer:
lib/entity/event/entity.ex, line 6 at r1 (raw file):
event Created do
docme
lib/network/henforcer/network.ex, line 44 at r1 (raw file):
{true, network_exists_relay} | network_exists_error def network_exists?(network_id = %Network.ID{}) do
docme
lib/network/internal/network/connection.ex, line 71 at r1 (raw file):
with {:ok, _} <- result do if new_nic do
doc cache invalidation
lib/server/action/flow/motherboard.ex, line 82 at r1 (raw file):
end def setup_network(
doc + spec
lib/server/make/server.ex, line 27 at r1 (raw file):
do: server(entity, :npc, net_data) @spec server(Entity.t, Server.type, net_data) ::
net_data | nil
lib/story/action/flow/story.ex, line 14 at r1 (raw file):
@spec start_story(Entity.t, Story.Manager.t, Event.relay) :: {:ok, Story.Step.t} def start_story(entity, manager, relay) do
docme
Comments from Reviewable
Reviewed 6 of 6 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Closes #335
Incidental
2
to0
update_server_by_nip
andupdate_server_by_component
cache invalidation methodsThis change is