Closed renatomassaro closed 6 years ago
Minor change of plans:
I've decided to explicitly name process params as either src_*
or tgt_*
, where src
represents stuff that originated the process, while tgt
represents stuff that is targeted by the process. This will avoid dubious and potentially wrong code where process.file_id
actually was meant to be process.target_file_id
source_connection_id
would work as an identifier of what connection originated the process (may be nil if the process is local).Note that it's quite different from the already existing
connection_id
.connection_id
points to the object of the process.For instance, a player encrypting/hidding a connection, or starting an active firewall against a connection, would have that connection as the object, so
connection_id
would be used.source_connection_id
must be used in order to:source_connection_id
would automatically kill it (though this behaviour may be overridden by the process).source_connection_id
.When implementing this, make sure to:
connection_id
tosource_connection_id
, as the FTP connection created for the process acts as its origin connection. Same applies to BruteforceProcess, which creates a CRC connection.source_connection_id
to FileInstallProcess.source_connection_id
is closed, but also give the option to override this behaviour (use internalSIGCONND
or similar signal)