Closed renatomassaro closed 6 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/378.
Reviewed 111 of 123 files at r1, 12 of 12 files at r2. Review status: all files reviewed at latest revision, 5 unresolved discussions.
lib/event/utils.ex, line 7 at r2 (raw file):
alias Helix.Network.Query.Bounce, as: BounceQuery def fetch_bounce(bounce = %Bounce{}),
spec + docs
lib/event/loggable/flow.ex, line 85 at r2 (raw file):
defined, in which case the event will be pattern-matched against them. """ defmacro log(query, do: block) do
explain better how this works
lib/event/loggable/flow.ex, line 320 at r2 (raw file):
end def get_first_ip(nil, ip),
doc + spec (til the end of the file)
lib/software/websocket/requests/cracker/bruteforce.ex, line 82 at r2 (raw file):
update_meta(request, %{process: process}, reply: true) # REVIEW: Bad format
Review :tipping_hand_man:
lib/universe/bank/action/flow/bank_account.ex, line 43 at r2 (raw file):
meta = %{ network_id: NetworkQuery.internet().network_id, bounce_id: nil
it's not bounce_id
. Which means this isn't tested
Comments from Reviewable
Reviewed 4 of 4 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Closes #380. Closes #369. Closes #256.
:construction: :construction_worker_man: :building_construction: :boom:
Net
NetworkHenforcer.Bounce
(inventory?)TODO:
network_id
onServerPublic.connect_to_server/3
Incidental
NetworkFactory
:tada:destination_id
totarget_id
on Tunnelclient_nip
toHETypes
, as well asto_nip
conversion method onClientUtils
Helix.Client.Renderer
system (later onClientUtils
could be moved toHelix.Client
)TunnelFlow
assert_bounce
macro helper.[1] - They are, implicitly. AnyMap would call
connections_through_node
. Ifserver_id
is not the Tunnel'sgateway_id
ortarget_id
, then it always is a bounce. In that case, display connection (link) as bounce from (n-1) to (n+1) of typeconnection_type
.This change is![Reviewable](https://reviewable.io/review_button.svg)