HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Add proper bounce support #378

Closed renatomassaro closed 6 years ago

renatomassaro commented 6 years ago

Closes #380. Closes #369. Closes #256.

:construction: :construction_worker_man: :building_construction: :boom:

TODO:

Incidental


[1] - They are, implicitly. AnyMap would call connections_through_node. If server_id is not the Tunnel's gateway_id or target_id, then it always is a bounce. In that case, display connection (link) as bounce from (n-1) to (n+1) of type connection_type.


This change is Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/378.

renatomassaro commented 6 years ago

Reviewed 111 of 123 files at r1, 12 of 12 files at r2. Review status: all files reviewed at latest revision, 5 unresolved discussions.


lib/event/utils.ex, line 7 at r2 (raw file):

  alias Helix.Network.Query.Bounce, as: BounceQuery

  def fetch_bounce(bounce = %Bounce{}),

spec + docs


lib/event/loggable/flow.ex, line 85 at r2 (raw file):

  defined, in which case the event will be pattern-matched against them.
  """
  defmacro log(query, do: block) do

explain better how this works


lib/event/loggable/flow.ex, line 320 at r2 (raw file):

  end

  def get_first_ip(nil, ip),

doc + spec (til the end of the file)


lib/software/websocket/requests/cracker/bruteforce.ex, line 82 at r2 (raw file):

        update_meta(request, %{process: process}, reply: true)

      # REVIEW: Bad format

Review :tipping_hand_man:


lib/universe/bank/action/flow/bank_account.ex, line 43 at r2 (raw file):

    meta = %{
      network_id: NetworkQuery.internet().network_id,
      bounce_id: nil

it's not bounce_id. Which means this isn't tested


Comments from Reviewable

renatomassaro commented 6 years ago

Reviewed 4 of 4 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable