Enable Steps to be restarted

renatomassaro commented 6 years ago

Closes #333. Closes #274.

Now you can delete your cracker and still proceed with the tutorial! :tada:

Unlike Steppable.start, Steppable.restart seems generic (it does not change for each step) and as such can be abstracted into a single function, so I think there's no need to implement it on each Step declaration. Due to a tiny detail (checkpoint (email) metadata is defined on the restart method), this cannot be done. A refactor where we make the whole Step interface 100% declarative would solve this, but there's no time for that.

Renamed Steppable.fail to Steppable.restart. Failure no longer exists :raised_hands:.
Split old Steppable.setup/1 into two parts, Steppable.start/1 and Steppable.setup/1. Now the setup only does the setup, and is reused at Steppable.restart.
Steppable.setup/1 must be idempotent, so existing code was updated.
setup_once macro to quickly enable idempotent object search/creation at Steppable.setup
Added FileDeletedEvent. Proper handlers on FilesystemHandlers are missing.
StoryQuery.Setup for standardized idempotency search during Steppable.setup
Removed FK on story_emails

This change is

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

renatomassaro commented 6 years ago

Reviewed 10 of 28 files at r1, 35 of 35 files at r2. Review status: all files reviewed at latest revision, 8 unresolved discussions.

        },
        "DownloadCracker": {
          "filters": ["File.Downloaded"],

Also filters File.Deleted (btw File.Deleted and Step.Restarted must be added to the JSON file)


  # Existing entries being removed
  # TODO FileDeletedEvent

Create issue

    do: generic_send(step, reply_id, :player)

  def rollback_email(step, email_id, meta) do

doc + spec

  end

  defmacro setup_once(object, identifier, do: block),

docme

  end

  def rollback_email(entry, email_id, meta) do

doc + spec

  end

  defp do_rollback_email(changeset, email) do

defp should be placed at the end of the file

  end

  @doc """

Move these more important functions up

defmodule Helix.Test.Story.Vars do
  @moduledoc """
  This helper will inject (in a non-higienic way!)

Oops

Comments from Reviewable

renatomassaro commented 6 years ago

:zero: :cool:

Reviewed 7 of 7 files at r3. Review status: all files reviewed at latest revision, 8 unresolved discussions.