HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Return Database.Virus information on DatabaseIndex #395

Closed renatomassaro closed 6 years ago

renatomassaro commented 6 years ago

Now the virus information is returned on the DatabaseIndex, during the AccountBootstrap process. This should be enough for the Client to properly render virus information on the HackedDatabase and VirusPanel apps.

Incidental


This change is Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/395.

renatomassaro commented 6 years ago

Reviewed 26 of 26 files at r1, 3 of 3 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.


lib/entity/model/database/server.ex, line 142 at r2 (raw file):

      do: where(query, [d], d.server_id == ^id)

    def join_database_viruses(query) do

Spec


lib/entity/public/index/database.ex, line 128 at r2 (raw file):

  end

  defp render_virus(entry = %Database.Virus{}, entity_viruses) do

spec


Comments from Reviewable

renatomassaro commented 6 years ago

Reviewed 1 of 26 files at r1, 2 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable