Closed renatomassaro closed 6 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/395.
Reviewed 26 of 26 files at r1, 3 of 3 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.
lib/entity/model/database/server.ex, line 142 at r2 (raw file):
do: where(query, [d], d.server_id == ^id) def join_database_viruses(query) do
Spec
lib/entity/public/index/database.ex, line 128 at r2 (raw file):
end defp render_virus(entry = %Database.Virus{}, entity_viruses) do
spec
Comments from Reviewable
Reviewed 1 of 26 files at r1, 2 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Now the virus information is returned on the DatabaseIndex, during the AccountBootstrap process. This should be enough for the Client to properly render virus information on the
HackedDatabase
andVirusPanel
apps.Incidental
DatabaseServer
andDatabaseBankAccount
to submodules (Database.Server
andDatabase.BankAccount
)This change is