Closed renatomassaro closed 6 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/408.
Reviewed 141 of 141 files at r1. Review status: :shipit: complete! all files reviewed, all discussions resolved
lib/hell/hell/ecto_macros.ex, line 43 at r1 (raw file):
end defmacro cast_pk(changeset, field, pk) do
doc
lib/hell/hell/ecto_macros.ex, line 49 at r1 (raw file):
end defmacro put_pk(changeset, heritage, domain, opts \\ unquote([])) do
doc
lib/hell/hell/id.ex, line 78 at r1 (raw file):
do: :error def generate do
remove generate/0
lib/hell/hell/id.ex, line 82 at r1 (raw file):
end def generate(domain) when is_tuple(domain) or is_atom(domain),
@doc false
lib/hell/hell/id.ex, line 87 at r1 (raw file):
do: %__MODULE__{id: Helix.ID.generate(heritage, domain)} def get_field,
@doc false
Comments from Reviewable
Reviewed 4 of 4 files at r2. Review status: :shipit: complete! all files reviewed, all discussions resolved
Comments from Reviewable
Depends on #406. Closes #377.
Documentation at #377 and
lib/id/id.ex
.This change is![Reviewable](https://reviewable.io/review_button.svg)