HackerExperience / Helix

GNU Affero General Public License v3.0
53 stars 10 forks source link

Rewrite Log service #410

Open renatomassaro opened 6 years ago

renatomassaro commented 6 years ago

This will be a rather large PR meant to enhance (but mostly rewrite) the Log service.

The biggest improvement is that now logs are structured data with pre-defined types, as opposed to the old Log system who was simply a string, void of any context.

So we changed from:

String: "localhost downloaded file Cracker.crc (1.0) from 1.2.3.4"

to

Struct: {type: :download_gateway, file_name: "Cracker.crc (1.0)", ip: "1.2.3.4", network_id: "::"}

To the end user this change is transparent (the struct will be "translated" to the string above anyways). But this allows for:


Incidental


This change is Reviewable

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/410.