search

HackerN64 / HackerSM64

A Super Mario 64 decompilation repo based on CrashOveride95/ultrasm64 that aims to provide a flexible, easy-to-use base for creating romhacks.
328 stars 146 forks source link

Add more audio banks and add some occasional mappings for audio macros #777

Closed Reonu closed 2 months ago

Reonu commented 5 months ago

This change by arctic makes it easier to add SFX by adding extra audio channels for general use as well as opening up space in 00_sound_banks. It was an old commit lost to time and I think that shouldn't be the case since it makes adding SFX significantly less CBT

gheskett commented 4 months ago

You know what, nevermind; most of that seems like perf lotto of some sort (idk what else it could be). It's weird because code size should have decreased in this PR (apart from the 00_sound_player.s) so idk why this got such a bad dice roll.

EDIT: I'm dumb it probably still technically increased. But even still it should be completely insignificant.