Open aglab2 opened 4 months ago
Important question, does this screw over 4MB users?
Nope, in fact it should help 4MB users because levels will not have garbage in them with fast64 imports.
Can you rebase this onto develop/3.0.0
instead of 2.3? This is very much major release territory.
Rebased to develop/3.0.0
. Original 2.3.0 commit is available at https://github.com/aglab2/HackerSM64/commits/split-levels-2.3.0-squash/
Do not merge till PR https://github.com/Fast-64/fast64/pull/356 is in main
someone should really merge that honestly
Is there anything else here to be added to fast64, especially now that HackerSM64 detection is a thing that actually exists?
This PR introduces a new bank for vanilla objects split from the courses. This allows for the following nice improvements: 1) Vanilla objects can be used in multiple courses. For example it is common that binary hacks use TTC objects in multiple courses at once.
From level script it looks like
2) Vanilla courses were setup in such a way that fast64 imports prune most of the useless vanilla leftovers. Level geolayouts/collisions/models were moved in *.inc.c that fast64 overwrites.
Unfortunately, this PR is very gigantic and I am not sure I can do much about reducing its complextity but I would really appreciate if I can get this merged to make handling vanilla stuff significantly more convenient.