search

HackerSpace-PESU / Best11-Fantasycricket

Predicting the Best 11 for a fantasy cricket game
GNU Affero General Public License v3.0
24 stars 17 forks source link

Added categorized folder in data. Please review the PR. #12

Closed amoghku02 closed 3 years ago

amoghku02 commented 3 years ago

Issue#10: Added categorized folder in data. Please review the PR.

roysti10 commented 3 years ago

Heyy, great work a few changes though There are some players who have played for multiple countries, Ex: Boyd Rankin who played for both England and Ireland, you have only put him under Ireland, We would like you to segregate his England matches and Ireland matches and put each of them in the respective country. There are other players like that as well, you need to ensure it doesn't cause a problem

roysti10 commented 3 years ago

There are many more files like those, I think u got the general idea

roysti10 commented 3 years ago

Once you are done , do tell as there are a lot of files to review

roysti10 commented 3 years ago

Heyy, since there's no update on this for a long time, Im changing this PR to a draft. you can continue to work on it once your done, ill change it back