search

HackerSpace-PESU / Best11-Fantasycricket

Predicting the Best 11 for a fantasy cricket game
GNU Affero General Public License v3.0
24 stars 17 forks source link

Typing hints using pydantic #46

Open roysti10 opened 3 years ago

roysti10 commented 3 years ago

Is your feature request related to a problem? Please describe. Add type hints to the files inside fantasy_cricket. using pydantic and typing Additional context It would also be great if mypy was used for the checks and added to the CI

scientes commented 3 years ago

pydantic and typing are a good Start for type hints and type checking

roysti10 commented 3 years ago

pydantic seems like a solid choice for this. FastApi is also based on pydantic so seems like a solid choice to me

Thx for the suggestion