HackerSpace-PESU / Best11-Fantasycricket

Predicting the Best 11 for a fantasy cricket game
GNU Affero General Public License v3.0
24 stars 17 forks source link

Dockerfilesk #59

Closed scientes closed 3 years ago

scientes commented 3 years ago

lets look if the third attempt works^

roysti10 commented 3 years ago

was #56 Sorry, that was my bad

scientes commented 3 years ago

ok git you just achieved to confuse me

scientes commented 3 years ago

why is the dockerfile itself not in the changes

roysti10 commented 3 years ago

SHouldnt the dockerfiles have come too?

scientes commented 3 years ago

jup

scientes commented 3 years ago

ill fix it one mom

roysti10 commented 3 years ago

Its probably because git thinks the commit is already merged , cause the two commits before revert docker file reference the initial commits in #56

scientes commented 3 years ago

jup ill merge the feature final branch into this one and make the commits again

scientes commented 3 years ago

still need to test if it works

scientes commented 3 years ago

is that a sign that it works? image

roysti10 commented 3 years ago

Yeaa!! Don't mind the white background I removed the image directory So that happened Will fix it soon

scientes commented 3 years ago

then lets merge

roysti10 commented 3 years ago

I need to test it though

docker build .
docker compose up -d

right?

scientes commented 3 years ago

I need to test it though

docker build .
docker compose up -d

right?

sudo docker build --pull --rm -f "DOCKERFILE" -t best11fantasycricket:latest "." sudo docker-compose up -d

was my approach but sudo docker build -f "DOCKERFILE" -t best11fantasycricket:latest "." should also work

roysti10 commented 3 years ago

You wouldnt have to use sudo if you do follow this Also if you rename the files as Dockerfile and Dockerfile.development you wouldnt have to use the -f tag as well

scientes commented 3 years ago

You wouldnt have to use sudo if you do follow this Also if you rename the files as Dockerfile and Dockerfile.development you wouldnt have to use the -f tag as well

yea i coudn't bother until now on my local machine

scientes commented 3 years ago

docker build -t best11fantasycricket:latest "." should work

roysti10 commented 3 years ago

dumb question but what url do i search? is it localhost:8000 itself? Cause 8000 doesnt seem to work

Got its 8080 just had to do docker ps xD

scientes commented 3 years ago

yeah beacuse localhost 80 sometimes causes hicups

roysti10 commented 3 years ago

It works, there are still some complications with the crawler But thats my issue , ill have to look into it

Once the frontend and this issue is resolved, we can start the hosting process Thank you for contributing