search

HackerThemes / spur-template

A Bootstrap Admin Template
https://hackerthemes.com/bootstrap-templates/spur
MIT License
358 stars 73 forks source link

separate bootstrap.css and spur.css #1

Open visavi opened 5 years ago

visavi commented 5 years ago

Mixing and editing bootstrap is bad practice, it’s better that they are separated and the styles overlap the original

arechsteiner commented 5 years ago

Bad practice? Would you source or reason this claim?

Editing Bootstrap the way I'm doing it is documented here: https://getbootstrap.com/docs/4.2/getting-started/theming/

I'm simply adding the spur stuff afterwards so I can use the variables and mixins in spur as well without much fuss. I'm not sure what benefit splitting up the customized Bootstrap and the Spur styles would bring. Spur relies on Bootstrap 100%.

visavi commented 5 years ago

If you abandon the project, it will be hard to upgrade to the new bootstrap version. here for example https://stackoverflow.com/questions/20721248/how-can-i-override-bootstrap-css-styles

arechsteiner commented 5 years ago

That is indeed a drawback but I don't see a way around it.

Overwriting all the Bootstrap styles manually just doesn't make sense if Bootstrap has this powerful theming infrastructure where you set one variable and then all the buttons look differently.

For other projects doing bootstrap.css and custom.css as in the StackOverflow thread is great, but that threat is also from 2013 when Bootstrap didn't have such a good customization setup.