search

HackerspaceBremen / ArduinoPixels

2 stars 1 forks source link

Valgrind errors #6

Open michaelkoetter opened 10 years ago

michaelkoetter commented 10 years ago

Running the app in Valgrind shows multiple errors and memory leaks, these could potentially lead to problems and should be fixed.

https://gist.github.com/michaelkoetter/e1f3a2bbfed17c724b15

hrobeers commented 9 years ago

I will reduce the memory footprint and increase the performance by stack allocating the bitmaps in const objects. (heap allocation on microcontrollers should be avoided)

Meanwhile, I will check if I can solve these valgrind errors.

hrobeers commented 9 years ago

Feel free to assign this bug to me, as I'm working on it.

The "uninitialised values" errors are fixed in commit fbacb328107f6cb75bf6c738c61e3f5fabeb6ba1

The memory leaks are being fixed by stack allocating. This is work in progress on branch https://github.com/hrobeers/ArduinoPixels/tree/stack However, I'm not sure if I can fix the SDL related memory leaks.

I will do a pull request when finished.

michaelkoetter commented 9 years ago

Hi Hans, thanks for your help, it's much appreciated. Somehow I can't assign you (might be a permission issue on github), but it's good to know you're working on the issue :)

hrobeers commented 9 years ago

All SDL unrelated valgrind errors fixed in pull request #9