Closed clkent closed 3 years ago
MattIPv4
commented
3 years ago Quick thought I had - this shirt is very clearly a representation of a male or male presenting torso. Do we care to make it a more gender neutral image?
Agreed. Probably worth asking in DODX if we have any alternative imagery available?
If we do, great, let's swap it out.
If not, let's ship this as-is and then we can bring this up with the wider HF team to see if its something that they want to allot time to.
MattIPv4
commented
3 years ago A thought for mobile:
Instead of putting the t-shirt as the first thing a user sees, which forces the content even further below the fold, perhaps we instead use it as a background image and position it at the bottom of the hero content?
.home-hero {
background-image: url(http://0.0.0.0/assets/hero-mobile-tshirt-light-e7bdf6cacca3140f846da649f37e45fdc6f6a33b3e93ba546044d58dcbda3f0d.png);
background-position: bottom right;
background-size: 50% auto;
background-repeat: no-repeat;
padding-bottom: 60px;
margin-bottom: 100px;
}
clkent
commented
3 years ago @MattIPv4 pushed up a fix for the weirdness of having the nav bg color on each page - good catch. As for the T-shirt positioning on mobile... I swapped the position so the T-shirt shows after the other content. Think it looks better than having it positioned right with the logos left while still accomplishing what you're pointing out.
Description
This PR is for DODX-1513 which is a request to swap out the hero with the new design that showcases the T-shirt.
Quick thought I had - this shirt is very clearly a representation of a male or male presenting torso. Do we care to make it a more gender neutral image?