Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.

https://hacktoberfest.digitalocean.com

Other

496 stars 145 forks source link

Update templates for winning/incomplete users #557

Closed katjuell closed 3 years ago

katjuell commented 3 years ago

Description

Updates for winning and waiting states.

Test process

Test with a user in various states:

won_shirt: Should display display_coupons with the correct copy.
completed: Should display waiting_for_prize with the correct copy.
incompleted: Should display thank_you with the correct copy.
waiting and END_DATE.past? (update in .env): Should display waiting_thank_you with the correct copy.

Requirements to merge

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

katjuell commented 3 years ago

Ah yes! Let me post about that in the copy doc & see if we can get some recommendations.