Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.

https://hacktoberfest.digitalocean.com

Other

496 stars 145 forks source link

Dodx 1511 show almost there message #564

Closed jonverson closed 3 years ago

jonverson commented 3 years ago

Description

Added in logic to show your almost there logic after the 4 PR and the timer is showing

Test process

If you go to the profile page with with at least 4 PR's and at least one of them has the timer you will get the almost there.

Requirements to merge

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

jonverson commented 3 years ago

Hey @MattIPv4 - I made some updates which is how I believe it should work. Let me know if I am misunderstanding anything. I updated the scoring_pull_requests method to include eligible and waiting pr's. Then in the timeline partial I will show the your almost there message if you have had 4 eligible or waiting PR's and you haven't won yet. If you have won it will show the you won message instead after the 4th PR.

jonverson commented 3 years ago

@MattIPv4 - I updated the logic for showing the your almost there message and you won message. Moved this logic into the pr partial. This PR should also cove the bonus icons. It will show all icons that are eligible that are over the 4 PR's as bonus ones.

jonverson commented 3 years ago

@MattIPv4 - I have those changes up for you on this branch.