search

Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Date [Year] incorrect in GitHub Workflows/test.yml #602

Closed sjchoure closed 3 years ago

sjchoure commented 3 years ago

Describe the bug

      START_DATE: "2019-10-01 00:00:00 UTC"
      RULES_DATE: "2019-10-01 00:00:00 UTC"
      END_DATE: "2019-11-01 00:00:00 UTC"

All dates have a year as 2019 and not 2020

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/digitalocean/hacktoberfest/blob/master/.github/workflows/test.yml
  2. See Line number 25 through 27

Expected behavior The year should be 2020 in each Dates

Screenshots Dates

Additional context Saw this discrepancy in PR #601

MattIPv4 commented 3 years ago

These dates don't need to be correct. The app was originally written in 2019 so using those dates should be fine, the app should still function the same.

We also actually overwrite those in the test logic itself to be based on the current time. Overall, not something that needs to be addressed -- thanks for bringing it up though!