search

Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Validation unclear on first registration page #610

Closed SilverCory closed 3 years ago

SilverCory commented 3 years ago

Describe the bug There is no validation when clicking the 'continue' button on the first page of registration. Meaning if no required fields are completed the user is in the dark as to why the form won't submit.

To Reproduce Steps to reproduce the behavior:

  1. Go to register
  2. Click continue
  3. Watch video accept terms and conditions and click 'start hacking'
  4. No visible error

Expected behavior The inability to continue on to the next page without validation of email address and ts&cs.

Additional context https://github.com/digitalocean/hacktoberfest/blob/8b48009228ad0f1abd05d933246b4c6674e03681/app/views/users/registration.html.erb#L65 This continue button.

SilverCory commented 3 years ago

image image

katjuell commented 3 years ago

Resolved in #607