Closed MattIPv4 closed 3 years ago
Nice to see those changes, I hope they will allow real contributors to have wider choice of repositories while limiting amount of spam. However, I have some questions:
hacktoberfest-accepted
label have to be merged to count?hacktoberfest
topic before this change is released, will it still count once hacktoberfest-accepted
label is added and this change is released?hacktoberfest-accepted
label even though PR has already been accepted or merged.Just to preface this, these changes are very much still in the internal proposal stage and may not happen, but having this PR up hopefully will help with getting some feel for the community sentiment on such a change.
Now, to your questions:
Do PRs with hacktoberfest-accepted label have to be merged to count?
Nope, the same rules will still apply around accepting a PR, so when it is opted-in with hacktoberfest-accepted
this will also accept it at the same time.
If PR is made to some repository without hacktoberfest topic before this change is released, will it still count once hacktoberfest-accepted label is added and this change is released?
Yup, every 2 hours we check the state of every PR a user has. If this change gets made, it'll also apply to any PRs already in existence.
What are the reasons that you don't count just any merged or accepted PR? Because if not, contributors would then have to beg maintainers to add hacktoberfest-accepted label even though PR has already been accepted or merged.
Based on overwhelming community feedback, we have decided to make Hacktoberfest explicitly opt-in. Accepting all merged/approved PRs on GitHub globally would not be opt-in, using the hacktoberfest
topic or hacktoberfest-accepted
label makes the opt-in decision explicit.
Description
Allow individual PRs to opt-in to the event with the
hacktoberfest-accepted
label, without the repository having thehacktoberfest
topic.Updated post copy:
Updated details:
Updated rules:
Updated maintainers info:
Updated timeline legend:
Test process
hacktoberfest-accepted
label, shows as waitinghacktoberfest-accepted
label, shows as waitingRequirements to merge