search

Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Add QA checks to ensure code quality #623

Open pandafy opened 3 years ago

pandafy commented 3 years ago

Feature description

While working on https://github.com/digitalocean/hacktoberfest/pull/617 I encountered that some files have trailing white spaces. I have configured my code editor to automatically trim while spaces. Since white spaces can be added by anyone and could sneak through reviews, I recommend adding QA checks to make sure they are absent and does not affect code quality.

MattIPv4 commented 3 years ago

+1 to this, we should be linting html/css

naomi-lgbt commented 3 years ago

Ooooh can I poke at this? I'm addicted to GitHub actions 😅

MattIPv4 commented 3 years ago

I'm not sure what the best practice is, but I imagine rubocop can lint .html.erb files directly, and then yeah, we'll need a new job (& docs) for running sass-lint or w/e

MattIPv4 commented 3 years ago

But yes, go for it!