search

Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Tooltip text on the icons. #627

Closed ashutoshshisodia closed 3 years ago

ashutoshshisodia commented 3 years ago

Feature description

There must be tooltip text on icons (when hovered) of ineligible repo, pending PR, etc in profile section. It is more convenient like that rather going at bottom and seeing the reference for the icons. Please help me fix it. Suggest where should I start ?

MattIPv4 commented 3 years ago

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/views/users/show/pr/_pr.html.erb#L4-L6

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/views/users/show/pr/_icon.html.erb#L1-L26

reginaalyssa commented 3 years ago

Hi is this issue still available? I'd like to try and take this on if it hasn't been taken yet. :)

MattIPv4 commented 3 years ago

@reginaalyssa Yeah, looks like it, go for it :)

reginaalyssa commented 3 years ago

Awesome, will work on this! Is there any specific look we're going for on the tooltip or would it just be a regular grey background for both light and dark mode?

MattIPv4 commented 3 years ago

Whatever you think looks/works best :)

reginaalyssa commented 3 years ago

Got it! I've opened a pull request for this just now. I just have a few items I need some help on, mostly on tests. Thanks! :)

ashutoshshisodia commented 3 years ago

Hey @reginaalyssa congratss!! and sorry @MattIPv4 I was greatly busy after creating the issue hence could not give time to it :( .