Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Incorrect current number of pull requests in progress #628

Closed dvlden closed 3 years ago

dvlden commented 3 years ago

Describe the bug I have more than 4 PRs and the number that indicates current/total number of PRs, fails to reflect that. Instead of displaying 8/4, it displays 4/4 consistently. Yes, the criteria are met, but why it doesn't count above 4 PRs?

To Reproduce Steps to reproduce the behavior:

  1. Go to Profile
  2. Get over 4 pull requests
  3. Look at the progress

Expected behavior It should display the current amount of pull requests.

Screenshots Screenshot 2020-10-06 at 08 37 46

MattIPv4 commented 3 years ago

There is a bonus count that will show below this when you have more than four valid PRs.

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/views/users/show.html.erb#L21-L26

The logic for bonus should be updated to include waiting PRs, in the same way the 4/4 score considers waiting PRs.

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/presenters/profile_page_presenter.rb#L58-L60

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/models/user.rb#L148-L150

dvlden commented 3 years ago

It does not render while PRs are In Review.

Your PR has been accepted by a maintainer and is currently within the review period, which lasts for fourteen days.

Is that the correct behavior?

MattIPv4 commented 3 years ago

The bonus score should be updated to include In Review (waiting) PRs, so that it matches the behaviour of the primary score (4/4).

dvlden commented 3 years ago

Alright then, it's a bug. I have 5 PRs that are in review and yet, I don't see any bonus box being rendered anywhere on the page.